Add enums to echidna printer's list of constants #1665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crytic/echidna#918.
This PR makes the echidna printer count enum values as uint256 constants, including them in the
"constants_used"
list so that echidna is aware of them. Currently, when a function has enum arguments, echidna will try all numbers, not privileging in-range enum values over out-of-range values.Example:
Before this PR, echidna takes a very long time to break the contract (didn't break it in 500000 iterations when I ran it). Afterwards, it breaks the contract nearly instantly.
I chose to make enum values be considered uint256 constants rather than uint8 constants since some versions of solidity allow for enums with more than 256 values.