Fix shadowing-function detector and enhance inheritance-graph#166

Merged

montyly merged 18 commits intodevfrom dev-inheritance

Feb 7, 2019

+317-82

Commits on Feb 6, 2019

Fix shadowing-function detector (and add modifiers to the results).
Xenomega
committed
* Added c3-linearization-internal detector to help inheritance-graph highlight collisions via C3 linearization.
Xenomega
committed
Remove internal detectors, moved internal inheritance detector logic into slither.utils.inheritance_analysis.
Xenomega
committed
inheritance-graph: Only highlight shadowed functions (not shadowing).
Xenomega
committed
Updates to inheritance_analysis.py's detect_function_shadowing to not include c3 collisions which end up neutralized by later inheriting contracts in a multi-inheritance scheme.
Xenomega
committed
* Added state variable shadowing detection to inheritance_analysis.
Xenomega
committed
* Numbered edges in inheritance-graph to denote order of inheritance.
Xenomega
committed
* Changed inheritance-graph to only show variables explicitly defined in the parent contract, instead of inherited.
Xenomega
committed
Updated test for less bloat + better readability in graph.
Xenomega
committed
Changed inheritance-graph shadowing state variable color to red (as it's most likely an error).
Xenomega
committed
inheritance-graph: Give digraph a blank name, otherwise it will be interpretted as "%0" and will be used as the title/tooltip for all blank space.
Xenomega
committed