Missing references fix #1604
Merged
Missing references fix #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart1e
requested review from
montyly,
0xalpharush and
smonicas
as code owners
|
@bart1e If possible, would you mind adding a test here please? https://github.com/crytic/slither/blob/master/tests/test_source_mapping.py |
|
@0xalpharush Of course, I will try to add them tomorrow. |
…sting to user defined types
bart1e
force-pushed
the
missing_references_fix
branch
from
ff5e508 to
5b09336
Compare
|
That's great, thanks @bart1e |
bart1e
added a commit
to bart1e/slither
that referenced
this pull request
Feb 14, 2023
bart1e
added a commit
to bart1e/slither
that referenced
this pull request
Feb 15, 2023
bart1e
added a commit
to bart1e/slither
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with user defined aliases (using
type [...] is [...]statement) - theirreferenceslist is not updated during parsing.Also, user defined types (contracts, interfaces, etc.) have missing references when casting (
TypeConversionexpressions).This PR fixes these issues and is needed to simplify code in #1592.