Detector for unused imports

slither/detectors/all_detectors.py

@@ -52,6 +52,7 @@
 from .statements.boolean_constant_misuse import BooleanConstantMisuse
 from .statements.divide_before_multiply import DivideBeforeMultiply
 from .statements.unprotected_upgradeable import UnprotectedUpgradeable
+from .statements.unused_imports import UnusedImports
 from .slither.name_reused import NameReused
 
 from .functions.unimplemented import UnimplementedFunctionDetection

tests/e2e/detectors/snapshots/detectors__detector_UnusedImports_0_8_16_C_sol__0.txt

@@ -0,0 +1,12 @@
+Unused imports found in /home/bart/Documents/TOB/slither/tests/e2e/detectors/test_data/unused-imports/0.8.16/B.sol.
+Consider removing the following imports:
+tests/e2e/detectors/test_data/unused-imports/0.8.16/A.sol
+
+
+Unused imports found in /home/bart/Documents/TOB/slither/tests/e2e/detectors/test_data/unused-imports/0.8.16/C.sol.
+Consider removing the following imports:
+tests/e2e/detectors/test_data/unused-imports/0.8.16/B.sol
+and adding the following:
+tests/e2e/detectors/test_data/unused-imports/0.8.16/A.sol
+
+

tests/e2e/detectors/test_data/unused-imports/0.8.16/A.sol

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+library A
+{
+    function a() public
+    {
+
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/B.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./A.sol";
+
+contract B
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/C.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./B.sol";
+
+contract C
+{
+    constructor()
+    {
+        A.a();
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantContractLevel.sol

@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+library ConstantContractLevel
+{
+    uint constant public CONSTANT = 0;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantContractLevelUsedInContractTest.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./ConstantContractLevel.sol";
+
+contract ConstantContractLevelUsedInContractTest
+{
+    uint private v = ConstantContractLevel.CONSTANT;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantContractLevelUsedTopLevelTest.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./ConstantContractLevel.sol";
+
+uint constant __ = ConstantContractLevel.CONSTANT;
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantTopLevel.sol

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+uint constant ConstantTopLevel = 0;
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantTopLevelUsedInContractTest.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./ConstantTopLevel.sol";
+
+contract ConstantTopLevelUsedInContractTest
+{
+    uint private v = ConstantTopLevel;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ConstantTopLevelUsedTopLevelTest.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./ConstantTopLevel.sol";
+
+uint constant __ = ConstantTopLevel;
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy_
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/Contract.sol

@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+contract Contract
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ContractUsedInContractTest1.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./Contract.sol";
+
+contract ContractUsedInContractTest1
+{
+    Contract c;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ContractUsedInContractTest2.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./Contract.sol";
+
+contract ContractUsedInContractTest2 is Contract
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/ContractUsedTopLevelTest.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./Contract.sol";
+
+Contract constant c = Contract(address(0x0));
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomErrorTopLevel.sol

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+error err();
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomErrorTopLevelUsedInContractTest.sol

@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomErrorTopLevel.sol";
+
+contract CustomErrorTopLevelUsedInContractTest
+{
+    constructor()
+    {
+        f();
+    }
+
+    function f() private pure
+    {
+        revert err();
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomEventContractLevel.sol

@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+library CustomEventContractLevel
+{
+    event CustomEvent();
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomEventContractLevelUsedInContractTest.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomEventContractLevel.sol";
+
+contract CustomEventContractLevelUsedInContractTest
+{
+    function f() public 
+    {
+        emit CustomEventContractLevel.CustomEvent();
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomEventContractLevelUsedTopLevelTest.sol

@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomEventContractLevel.sol";
+
+function f()
+{
+    emit CustomEventContractLevel.CustomEvent();
+}
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevel.sol

@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+contract CustomTypeContractLevel
+{
+    type CustomType is uint;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedInContractTest1.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+contract CustomTypeContractLevelUsedInContractTest1
+{
+    CustomTypeContractLevel.CustomType private v;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedInContractTest2.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+contract CustomTypeContractLevelUsedInContractTest2
+{
+    function f(CustomTypeContractLevel.CustomType) public 
+    {
+
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedInContractTest3.sol

@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+contract CustomTypeContractLevelUsedInContractTest3
+{
+    modifier m()
+    {
+        CustomTypeContractLevel.CustomType ___;
+        _;
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedInContractTest4.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+contract CustomTypeContractLevelUsedInContractTest4
+{
+    struct CustomStruct
+    {
+        CustomTypeContractLevel.CustomType ___;
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedTopLevelTest1.sol

@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+struct CustomTypeContractLevelUsedTopLevelTest1
+{
+    CustomTypeContractLevel.CustomType __;
+}
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeContractLevelUsedTopLevelTest2.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeContractLevel.sol";
+
+CustomTypeContractLevel.CustomType constant __ = CustomTypeContractLevel.CustomType.wrap(0);
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeTopLevel.sol

@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+type CustomType is uint;
+
+// dummy contract, so that "No contract were found ..." message is not being thrown by Slither
+contract Dummy
+{
+
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeTopLevelUsedInContractTest1.sol

@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeTopLevel.sol";
+
+contract CustomTypeTopLevelUsedInContractTest1
+{
+    CustomType private v;
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeTopLevelUsedInContractTest2.sol

@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeTopLevel.sol";
+
+contract CustomTypeTopLevelUsedInContractTest2
+{
+    function f(CustomType) public 
+    {
+
+    }
+}

tests/e2e/detectors/test_data/unused-imports/0.8.16/CustomTypeTopLevelUsedInContractTest3.sol

@@ -0,0 +1,13 @@
+// SPDX-License-Identifier: Unlicense
+pragma solidity 0.8.16;
+
+import "./CustomTypeTopLevel.sol";
+
+contract CustomTypeTopLevelUsedInContractTest3
+{
+    modifier m()
+    {
+        CustomType v;
+        _;
+    }
+}