Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to type_alias #1576

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add type to type_alias #1576

merged 1 commit into from
Jan 11, 2023

Conversation

montyly
Copy link
Member

@montyly montyly commented Jan 10, 2023

Adding type will help with directly access, like in

slither/slither/core/cfg/node.py

Line 911 in 7ea5727

self._high_level_calls.append((ir.destination.type.type, ir.function))

@0xalpharush
Copy link
Contributor

It'd be nice to have a test for this

@montyly montyly mentioned this pull request Jan 11, 2023
Open
@montyly montyly merged commit ac4742f into dev Jan 11, 2023
@montyly montyly deleted the dev-improve-type-alias branch January 11, 2023 09:37
@0xalpharush 0xalpharush mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xalpharush 0xalpharush 0xalpharush approved these changes

@smonicas smonicas Awaiting requested review from smonicas smonicas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montyly @0xalpharush