Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/solc parsing #1565

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from
Draft

Rewrite/solc parsing #1565

wants to merge 26 commits into from

Conversation

0xalpharush
Copy link
Contributor

@0xalpharush 0xalpharush commented Jan 6, 2023

This PR updates @samczsun's work on #627 to be compatible with addition of SlitherCompilationUnit and the addition of things like user defined value types and unchecked blocks. This greatly improves the typing of the code

I think the failing tests might just need to be updated rather than conformed to:

  • the test conditional-all is failing parser tests bc the node id changes but the CFG is the same
  • some of the reentrancy tests fail bc the existing implementation doesn't create a tuple with None for (success,) = call()

TODO:

  • fix linting
  • add types for symbol alias and using for parsing and move out of compilation unit

@0xalpharush 0xalpharush marked this pull request as ready for review January 26, 2023 23:32
@0xalpharush 0xalpharush force-pushed the rewrite/solc_parsing branch from 76009e2 to a091e8c Compare March 13, 2023 04:40
@0xalpharush 0xalpharush marked this pull request as draft June 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant