Filter upgradeability checks by name/impact #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for slither-check-upgradeability
for slither-check-upgradeability
and fix references
which caused CI test to fail
|
This is great, thanks @webthethird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #936.
Follows the same approach as the equivalent argument options in the main Slither module, with options to selectively enable/disable checks by name using comma separated lists, and to exclude checks according to impact level.
Does not currently provide an option to enable only a given impact level (i.e., the opposite of
--exclude-<IMPACT>), but implementing this would be trivial if desired.