Fix ExtraVariablesProxy upgradeability check
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and by inheritance, also fix `ExtraVariablesNewContract`. This check was reporting too many variables, because it was starting at `idx = len(order2) - len(order1)`. So, if the new contract (or proxy) had 12 variables, and the original contract had 10, it was reporting every variable starting at `idx = 2`, whereas it should have only been reporting those starting at `idx = len(order1)`.
|
Any idea why the Dapp test check failed here? This PR is a very simple fix, limited to just the one line, so I can't imagine the failed test has anything to do with the small change I made. |
|
@webthethird There's a fix in |
Done! And thanks @elopez for switching the base branch, makes sense to me. |
|
great catch. Thanks @webthethird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and by inheritance, also fix
ExtraVariablesNewContract.This check was reporting too many variables, because it was starting at
idx = len(order2) - len(order1).So, if the new contract (or proxy) had 12 variables, and the original contract had 10, it was reporting every variable starting at
idx = 2, whereas it should have only been reporting those starting atidx = len(order1).