Call value ternary #1501
Merged
Call value ternary #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montyly
reviewed
Dec 20, 2022
| if isinstance(next_expr.expression_right, ConditionalExpression): | ||
| next_expr = _handle_ternary_access( | ||
| next_expr, true_expression, false_expression | ||
| # TODO: can we get rid of `NoneType` expressions in `TupleExpression`? |
There was a problem hiding this comment.
Not sure, my intuition tells me that could happen with unnamed tuple (ex: (,,,) = f()). Through I haven't tested, so I could be wrong
| self.copy_expression( | ||
| next_expr, true_expression.expression, false_expression.expression | ||
| ) | ||
|
|
||
| # pylint: disable=too-many-nested-blocks |
There was a problem hiding this comment.
Can we move part of the function's logic into internal functions?
This would reduce the code complexity, and allows us to remove this warning
0xalpharush
commented
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close [Bug-Candidate]: Ternary operation not handled None(<class 'NoneType'>) #1153, close [Bug]: Ternary operation not handled bytes #1371, close [Bug-Candidate]: Support concat functionality of dynamic sized arrays - Solidity ^0.8.12 #1198
Replace Unused ternary param #1217