Improve support using for directive #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2022
|
What's the state of this PR? |
|
@CodeSandwich this should work on your codebase now. Lmk if you find additional issues |
0xalpharush
reviewed
Dec 13, 2022
0xalpharush
reviewed
Dec 13, 2022
| @@ -574,21 +574,26 @@ def analyze_state_variables(self): | |||
| except (VariableNotFound, KeyError) as e: | |||
| self.log_incorrect_parsing(f"Missing state variable {e}") | |||
|
|
|||
| def analyze_using_for(self): | |||
| def analyze_using_for(self): # pylint: disable=too-many-branches | |||
| try: | |||
| for father in self._contract.inheritance: | |||
| self._contract.using_for.update(father.using_for) | |||
There was a problem hiding this comment.
@smonicas One thing I wasn't sure about is if there'd be a reason we also need to update child contracts' using_for_complete
There was a problem hiding this comment.
I don't think there is a need because the first use of using_for_complete is when converting to slithir which comes after parsing is finished
montyly
requested changes
Jan 4, 2023
|
|
||
| def _analyze_library_function(self, function_name: str, type_name: Type) -> None: | ||
| function_name_split = function_name.split(".") | ||
| # TODO this doesn't handle the case if there is an import with an alias |
There was a problem hiding this comment.
Can we open a separate issue to track this, with an example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352