Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Printer to JSON #286

Closed
9 tasks
montyly opened this issue Jun 27, 2019 · 41 comments
Closed
9 tasks

Export Printer to JSON #286

montyly opened this issue Jun 27, 2019 · 41 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@montyly
Copy link
Member

montyly commented Jun 27, 2019

Task Description

We want to add a printer output similar to our JSON wrapping output for the detector

  • Classify the printer per output types (ex: text, dot generation, ...)
  • Severalize the output to be sent through JSON
  • Add the JSON printer output to our standard JSON

Acceptance criteria

  • Slither JSON output can contain any printer results
  • An update of the JSON documentation is prepared
  • Unit tests for printers, based on the JSON output are prepared.

Required Skills

  • Experience with Python 3.6
  • Experience with Solidity smart contracts
  • Experience with Slither

This issue requires to discuss with me to design a proper output format and requires good programming skills.

Feel free to ask questions here, or join our slack (#ethereum)
@montyly montyly added enhancement New feature or request help wanted Extra attention is needed labels Jun 27, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) man-jain has applied to start work (Funders only: approve worker | reject worker).

I have a good experience with Python and JSON, and can solve this issue.

Learn more on the Gitcoin Issue Details page.

@spm32
Copy link

spm32 commented Jul 11, 2019

Hi @Man-Jain glad to have you working on this, please try to make consistent WIP PRs and let us know if you run into any trouble.

@Man-Jain
Copy link

Man-Jain commented Jul 11, 2019 •
edited
Loading

Thanks, I'll surely put up some consistent PRs.

@Man-Jain
Copy link

The outputs given by the various printers are basically of two types :- 1. .dot file 2. text. Also currently the printers aren't programmed yet to return output. So the first step would be to enable the printers to return outputs.(Please correct me if I am wrong)

@gitcoinbot
Copy link

gitcoinbot commented Jul 13, 2019 •
edited
Loading

Issue Status: 1. Open 2. Cancelled

Workers have applied to start work.

These users each claimed they can complete the work by 1 year, 7 months ago.
Please review their action plans below:

1) jamessandy has applied to start work (Funders only: approve worker | reject worker).

Hello there, i've worked on similar project previously and i belive i can deliver in the least amount of time with minimal or no supervision if given just a chance .

Learn more on the Gitcoin Issue Details page.

Man-Jain added a commit to Man-Jain/slither that referenced this issue Jul 13, 2019
@Man-Jain
Add JSON output functionality for printers
08dd9f9 
This changes the code to return the result as output if --json argument
is passed to printers.

Solves crytic#286
@Man-Jain Man-Jain mentioned this issue Jul 13, 2019
Closed
@Man-Jain
Copy link

Man-Jain commented Jul 13, 2019 •
edited
Loading

@ceresstation I have submitted a patch. Please see and give some feedback.

@Man-Jain
Copy link

Man-Jain commented Jul 14, 2019 •
edited
Loading

@ceresstation and @montyly Please check the output format and give your comment so that I can move forward with writing tests and documentation for this.

@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Man-Jain
Copy link

I am still working on this issue. But the work I intend to do depends upon this pr to be merged.

@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Man-Jain
Copy link

Yes Still working on it

@spm32
Copy link

spm32 commented Jul 31, 2019

Thanks for the update @Man-Jain could you provide a WIP PR if it makes sense to do so?

Man-Jain added a commit to Man-Jain/slither that referenced this issue Jul 31, 2019
@Man-Jain
Add JSON output functionality for printers
af70df1 
This changes the code to return the result as output if --json argument
is passed to printers.

Solves crytic#286
Man-Jain added a commit to Man-Jain/slither that referenced this issue Jul 31, 2019
@Man-Jain
Add JSON output functionality for printers
696c1c7 
This changes the code to return the result as output if --json argument
is passed to printers.

Solves crytic#286
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@montyly
Copy link
Member Author

montyly commented Aug 23, 2019

For Gitcoin moderators: @Man-Jain has an ongoing PR and is waiting from a review from our side

@Man-Jain
Copy link

I have a open PR, waiting for review.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 10 months from now.
Please review their action plans below:

1) man-jain has applied to start work (Funders only: approve worker | reject worker).

It was showing that I had applied two times because of which I was not able to participate in other bounties. I have already started the work and am in touch with the maintainers

Learn more on the Gitcoin Issue Details page.

@spm32
Copy link

spm32 commented Sep 10, 2019

@Man-Jain just wanted to check in to see how this is going, thanks!

@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Man-Jain
Copy link

Yes

@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Man-Jain Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@Man-Jain due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@Man-Jain due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@spm32
Copy link

spm32 commented Oct 24, 2019

Hey @igetgames since we haven't heard back from @Man-Jain you're welcome to pick this up and complete it!

@montyly
Copy link
Member Author

montyly commented Oct 24, 2019

As the work did not progress, and this feature as a high priority for us, we end up working internally on it.

@ceresstation can you close the bounty? Thanks!

@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@montyly montyly closed this as completed in 23ea41e Nov 4, 2019
@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@igetgames Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Nov 7, 2019 •
edited
Loading

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 1 year, 7 months ago.
Please review their action plans below:

1) marcusrbrown has been approved to start work.

I'd like to pick this up and complete it.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled

The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled

The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

@leekt
Copy link

leekt commented Apr 22, 2020

Is this implemented or not? I really want this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spm32 @Man-Jain @montyly @leekt @gitcoinbot