[Bug-Candidate]: --disable-color ignored, printer produces colored outputs

[ongrid]

Describe the issue:

Flag --disable-color seem to be ignored and printer produces colored output with ASCII escape characters not suitable to capture into plaintext files

slither --help   
usage: slither target [flag]
Additional options:
...
  --disable-color       Disable output colorization

Workaround: pass the output through the following sed script:

slither . --print function-summary 2>&1 | sed 's/\x1b\[[0-9;]*m//g'

Code example to reproduce the issue:

Version:

slither --version
0.10.0

From docker image ghcr.io/trailofbits/eth-security-toolbox:nightly

Relevant log output:

No response

[elopez]

Thanks for the report @ongrid ! It looks like this printer uses MyPrettyTable to print a table, and that class always uses a colored table. Maybe the MyPrettyTable underlying implementation should choose to use the non-colored PrettyTable class when colors are disabled: https://github.com/jazzband/prettytable#changing-the-appearance-of-your-table---with-colors

[theexoticman]

Thanks, @elopez for the pointer. I took the liberty to propose a fix. Let me know if using an environment variable follows the dev best practices guidelines. I'll add a unit test after confirmation.