Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source mapping for lines are not always correct #180

Closed
defunctio opened this issue Feb 25, 2019 · 1 comment
Closed

Source mapping for lines are not always correct #180

defunctio opened this issue Feb 25, 2019 · 1 comment
Assignees
@montyly
Labels
bug Something isn't working High Priority

Comments

@defunctio
Copy link

The line numbers for issues reported by slither often don't line up to the source lines indicated. I don't have any public examples but it should be relatively easy to reproduce. I noticed when reviewing a contract with a lot of Conformance to Solidity naming conventions issues.
@defunctio defunctio added the bug Something isn't working label Feb 25, 2019
@montyly montyly self-assigned this Feb 25, 2019
Xenomega added a commit that referenced this issue Mar 29, 2019
@Xenomega
Fixed a bug where return carraiges would offset line number calculati…
ad4fc1b 
…ons (close #180)
@Xenomega Xenomega mentioned this issue Mar 29, 2019
Merged
@montyly
Copy link
Member

montyly commented Apr 1, 2019

Fixed with #194

@montyly montyly closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@montyly montyly

Labels
bug Something isn't working High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@montyly @defunctio