Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making exclude/ fail-on behavior more intuitive #1458

Closed
0xalpharush opened this issue Nov 7, 2022 · 0 comments
Closed

making exclude/ fail-on behavior more intuitive #1458

0xalpharush opened this issue Nov 7, 2022 · 0 comments
Assignees
@elopez
Milestone
0.9.4

Comments

@0xalpharush
Copy link
Contributor

0xalpharush commented Nov 7, 2022 •
edited
Loading

There's some confusion about the default behavior and prioritization of --exclude-* and --fail-on-* flags. For example, since --fail-on-pedantic is enabled by default, one must pass --exclude-informational --exclude-optimization --no-fail-pedantic to disable informational and optimization level detectors.

Current thinking:

  • Decouple fail and exclude
  • Create --fail-on Enum[optimization, informational, low, medium, high]

ref: crytic/slither-action#38, #1408
elopez added a commit to elopez/slither that referenced this issue Nov 8, 2022
@elopez
fail-on: rework feature
06d8a7a 
This adds a new `fail_on` config option that can be changed with
a mutually exclusive group of argument flags. It also decouples
the exclude_* and fail_on flags, so you can do things like
`fail_on: pedantic` while disabling optimization findings.
Additionally, this adds some new code to detect the old-style
config options, migrate their settings, and alert the user.

Fixes crytic#1458
elopez added a commit to elopez/slither that referenced this issue Nov 8, 2022
@elopez
fail-on: rework feature
38f1dd8 
This adds a new `fail_on` config option that can be changed with
a mutually exclusive group of argument flags. It also decouples
the exclude_* and fail_on flags, so you can do things like
`fail_on: pedantic` while disabling optimization findings.
Additionally, this adds some new code to detect the old-style
config options, migrate their settings, and alert the user.

Fixes crytic#1458
@elopez elopez mentioned this issue Nov 8, 2022
Merged
@0xalpharush 0xalpharush added this to the 0.9.4 milestone Apr 11, 2023
@0xalpharush 0xalpharush mentioned this issue May 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elopez elopez

Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

No branches or pull requests
2 participants
@elopez @0xalpharush