Merge pull request #1856 from crytic/dev-remove-assertion

Remove assertion in unary operation

slither/visitors/slithir/expression_to_slithir.py

@@ -626,7 +626,6 @@ def _post_unary_operation(self, expression: UnaryOperation) -> None:
             set_val(expression, value)
         elif expression.type in [UnaryOperationType.MINUS_PRE]:
             lvalue = TemporaryVariable(self._node)
-            assert isinstance(value.type, ElementaryType)
             operation = Binary(lvalue, Constant("0", value.type), value, BinaryType.SUBTRACTION)
             operation.set_expression(expression)
             self._result.append(operation)

tests/e2e/solc_parsing/test_ast_parsing.py

@@ -452,6 +452,7 @@ def make_version(minor: int, patch_min: int, patch_max: int) -> List[str]:
     Test("yul-top-level-0.8.0.sol", ["0.8.0"]),
     Test("complex_imports/import_aliases_issue_1319/test.sol", ["0.5.12"]),
     Test("yul-state-constant-access.sol", ["0.8.16"]),
+    Test("negate-unary-element.sol", ["0.8.16"]),
 ]
 # create the output folder if needed
 try:

tests/e2e/solc_parsing/test_data/expected/negate-unary-element.sol-0.8.16-compact.json

@@ -0,0 +1,5 @@
+{
+  "T": {
+    "a(int256[])": "digraph{\n0[label=\"Node Type: ENTRY_POINT 0\n\"];\n0->1;\n1[label=\"Node Type: RETURN 1\n\"];\n}\n"
+  }
+}

tests/e2e/solc_parsing/test_data/negate-unary-element.sol

@@ -0,0 +1,5 @@
+contract T {
+    function a(int256[] memory data) public returns(int256) {
+        return -data[0];
+    }
+}