bug: address issue #2107 add contract id in inheritance graph printer

slither/printers/abstract_printer.py

@@ -20,7 +20,7 @@ class AbstractPrinter(metaclass=abc.ABCMeta):
 
     WIKI = ""
 
-    def __init__(self, slither: "Slither", logger: Logger) -> None:
+    def __init__(self, slither: "Slither", logger: Optional[Logger]) -> None:
         self.slither = slither
         self.contracts = slither.contracts
         self.filename = slither.filename

slither/printers/inheritance/inheritance_graph.py

@@ -100,10 +100,11 @@ def _summary(self, contract):
 
         # Add arrows (number them if there is more than one path so we know order of declaration for inheritance).
         if len(contract.immediate_inheritance) == 1:
-            ret += f"{contract.name} -> {contract.immediate_inheritance[0]};\n"
+            immediate_inheritance = contract.immediate_inheritance[0]
+            ret += f"c{contract.id}_{contract.name} -> c{immediate_inheritance.id}_{immediate_inheritance};\n"
         else:
             for i, immediate_inheritance in enumerate(contract.immediate_inheritance):
-                ret += f'{contract.name} -> {immediate_inheritance} [ label="{i + 1}" ];\n'
+                ret += f'c{contract.id}_{contract.name} -> c{immediate_inheritance.id}_{immediate_inheritance} [ label="{i + 1}" ];\n'
 
         # Functions
         visibilities = ["public", "external"]
@@ -151,7 +152,7 @@ def _summary(self, contract):
         indirect_shadowing_information = self._get_indirect_shadowing_information(contract)
 
         # Build the node label
-        ret += f'{contract.name}[shape="box"'
+        ret += f'c{contract.id}_{contract.name}[shape="box"'
         ret += 'label=< <TABLE border="0">'
         ret += f'<TR><TD align="center"><B>{contract.name}</B></TD></TR>'
         if public_functions:

tests/e2e/printers/test_data/test_contract_names/A.sol

@@ -0,0 +1,4 @@
+contract A {
+    function a_main() public pure {}
+}
+

tests/e2e/printers/test_data/test_contract_names/B.sol

@@ -0,0 +1,8 @@
+import "./A.sol";
+
+contract B is A {
+    function b_main() public pure {
+        a_main();
+    }
+}
+

tests/e2e/printers/test_data/test_contract_names/B2.sol

@@ -0,0 +1,7 @@
+import "./A.sol";
+
+contract B is A {
+    function b2_main() public pure {
+        a_main();
+    }
+}

tests/e2e/printers/test_data/test_contract_names/C.sol

@@ -0,0 +1,7 @@
+import "./A.sol";
+
+contract C is A {
+    function c_main() public pure {
+        a_main();
+    }
+}

tests/e2e/printers/test_printers.py

@@ -0,0 +1,45 @@
+import re
+from collections import Counter
+from pathlib import Path
+
+from crytic_compile import CryticCompile
+from crytic_compile.platform.solc_standard_json import SolcStandardJson
+
+from slither import Slither
+from slither.printers.inheritance.inheritance_graph import PrinterInheritanceGraph
+
+
+TEST_DATA_DIR = Path(__file__).resolve().parent / "test_data"
+
+
+def test_inheritance_printer(solc_binary_path) -> None:
+    solc_path = solc_binary_path("0.8.0")
+    standard_json = SolcStandardJson()
+    standard_json.add_source_file(
+        Path(TEST_DATA_DIR, "test_contract_names", "A.sol").as_posix()
+    )
+    standard_json.add_source_file(
+        Path(TEST_DATA_DIR, "test_contract_names", "B.sol").as_posix()
+    )
+    standard_json.add_source_file(
+        Path(TEST_DATA_DIR, "test_contract_names", "B2.sol").as_posix()
+    )
+    standard_json.add_source_file(
+        Path(TEST_DATA_DIR, "test_contract_names", "C.sol").as_posix()
+    )
+    compilation = CryticCompile(standard_json, solc=solc_path)
+    slither = Slither(compilation)
+    printer = PrinterInheritanceGraph(slither=slither, logger=None)
+
+    content = ""
+    for contract in slither.contracts:
+        content += printer._summary(contract)
+
+    pattern = re.compile(r"(?:c\d+_)?(\w+ -> )(?:c\d+_)(\w+)")
+    matches = re.findall(pattern, content)
+    relations = ["".join(m) for m in matches]
+
+    counter = Counter(relations)
+
+    assert counter["B -> A"] == 2
+    assert counter["C -> A"] == 1