Merge pull request #1556 from elopez/dev-fix-etherscan-test

Fix and re-enable etherscan test
crytic · Jan 6, 2023 · bb19bce · bb19bce
2 parents 994cb5f + ac624bf
commit bb19bce
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,7 +29,7 @@ jobs:
                # "embark",
                "erc",
                # "etherlime",
-               # "etherscan"
+               "etherscan",
                "find_paths",
                "flat",
                "kspec",

diff --git a/scripts/ci_test_etherscan.sh b/scripts/ci_test_etherscan.sh
@@ -5,15 +5,24 @@
 mkdir etherscan
 cd etherscan || exit 255
 
-if ! slither 0x7F37f78cBD74481E593F9C737776F7113d76B315 --etherscan-apikey "$GITHUB_ETHERSCAN"; then
-    echo "Etherscan test failed"
+echo "::group::Etherscan mainnet"
+if ! slither 0x7F37f78cBD74481E593F9C737776F7113d76B315 --etherscan-apikey "$GITHUB_ETHERSCAN" --no-fail-pedantic; then
+    echo "Etherscan mainnet test failed"
     exit 1
 fi
+echo "::endgroup::"
 
-if ! slither rinkeby:0xFe05820C5A92D9bc906D4A46F662dbeba794d3b7 --etherscan-apikey "$GITHUB_ETHERSCAN"; then
-    echo "Etherscan test failed"
+# Perform a small sleep when API key is not available (e.g. on PR CI from external contributor)
+if [ "$GITHUB_ETHERSCAN" = "" ]; then
+    sleep $(( ( RANDOM % 5 )  + 1 ))s
+fi
+
+echo "::group::Etherscan rinkeby"
+if ! slither rinkeby:0xFe05820C5A92D9bc906D4A46F662dbeba794d3b7 --etherscan-apikey "$GITHUB_ETHERSCAN" --no-fail-pedantic; then
+    echo "Etherscan rinkeby test failed"
     exit 1
 fi
+echo "::endgroup::"
 
 exit 0