remove similar-names bc it's slow (#2469)

crytic · Jun 4, 2024 · b9a3ea6 · b9a3ea6
1 parent 23006f5
commit b9a3ea6
Show file tree

Hide file tree

Showing 15 changed files with 0 additions and 163 deletions.
diff --git a/slither/detectors/all_detectors.py b/slither/detectors/all_detectors.py
@@ -57,7 +57,6 @@
 from .functions.unimplemented import UnimplementedFunctionDetection
 from .statements.mapping_deletion import MappingDeletionDetection
 from .statements.array_length_assignment import ArrayLengthAssignment
-from .variables.similar_variables import SimilarVarsDetection
 from .variables.function_init_state_variables import FunctionInitializedState
 from .statements.redundant_statements import RedundantStatements
 from .operations.bad_prng import BadPRNG

diff --git a/slither/detectors/variables/similar_variables.py b/slither/detectors/variables/similar_variables.py
diff --git a/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_4_25_similar_variables_sol__0.txt b/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_4_25_similar_variables_sol__0.txt
diff --git a/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_5_16_similar_variables_sol__0.txt b/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_5_16_similar_variables_sol__0.txt
diff --git a/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_6_11_similar_variables_sol__0.txt b/...rs/snapshots/detectors__detector_SimilarVarsDetection_0_6_11_similar_variables_sol__0.txt
diff --git a/...ors/snapshots/detectors__detector_SimilarVarsDetection_0_7_6_similar_variables_sol__0.txt b/...ors/snapshots/detectors__detector_SimilarVarsDetection_0_7_6_similar_variables_sol__0.txt
diff --git a/tests/e2e/detectors/test_data/similar-names/0.4.25/similar_variables.sol b/tests/e2e/detectors/test_data/similar-names/0.4.25/similar_variables.sol
diff --git a/tests/e2e/detectors/test_data/similar-names/0.4.25/similar_variables.sol-0.4.25.zip b/tests/e2e/detectors/test_data/similar-names/0.4.25/similar_variables.sol-0.4.25.zip
diff --git a/tests/e2e/detectors/test_data/similar-names/0.5.16/similar_variables.sol b/tests/e2e/detectors/test_data/similar-names/0.5.16/similar_variables.sol
diff --git a/tests/e2e/detectors/test_data/similar-names/0.5.16/similar_variables.sol-0.5.16.zip b/tests/e2e/detectors/test_data/similar-names/0.5.16/similar_variables.sol-0.5.16.zip
diff --git a/tests/e2e/detectors/test_data/similar-names/0.6.11/similar_variables.sol b/tests/e2e/detectors/test_data/similar-names/0.6.11/similar_variables.sol
diff --git a/tests/e2e/detectors/test_data/similar-names/0.6.11/similar_variables.sol-0.6.11.zip b/tests/e2e/detectors/test_data/similar-names/0.6.11/similar_variables.sol-0.6.11.zip
diff --git a/tests/e2e/detectors/test_data/similar-names/0.7.6/similar_variables.sol b/tests/e2e/detectors/test_data/similar-names/0.7.6/similar_variables.sol
diff --git a/tests/e2e/detectors/test_data/similar-names/0.7.6/similar_variables.sol-0.7.6.zip b/tests/e2e/detectors/test_data/similar-names/0.7.6/similar_variables.sol-0.7.6.zip
diff --git a/tests/e2e/detectors/test_detectors.py b/tests/e2e/detectors/test_detectors.py
@@ -1453,26 +1453,6 @@ def id_test(test_item: Test):
         "type_based_tautology.sol",
         "0.7.6",
     ),
-    Test(
-        all_detectors.SimilarVarsDetection,
-        "similar_variables.sol",
-        "0.4.25",
-    ),
-    Test(
-        all_detectors.SimilarVarsDetection,
-        "similar_variables.sol",
-        "0.5.16",
-    ),
-    Test(
-        all_detectors.SimilarVarsDetection,
-        "similar_variables.sol",
-        "0.6.11",
-    ),
-    Test(
-        all_detectors.SimilarVarsDetection,
-        "similar_variables.sol",
-        "0.7.6",
-    ),
     Test(
         all_detectors.MsgValueInLoop,
         "msg_value_loop.sol",