Fix incorrect array_type in NewArray

crytic · Apr 21, 2023 · aadee32 · aadee32
1 parent 8f9fe80
commit aadee32
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/slither/core/expressions/new_array.py b/slither/core/expressions/new_array.py
@@ -1,5 +1,4 @@
-from typing import Union, TYPE_CHECKING
-
+from typing import TYPE_CHECKING
 
 from slither.core.expressions.expression import Expression
 

diff --git a/slither/solc_parsing/expressions/expression_parsing.py b/slither/solc_parsing/expressions/expression_parsing.py
@@ -559,19 +559,8 @@ def parse_expression(expression: Dict, caller_context: CallerContextExpression)
             type_name = children[0]
 
         if type_name[caller_context.get_key()] == "ArrayTypeName":
-            depth = 0
             array_type = parse_type(type_name, caller_context)
-            while type_name[caller_context.get_key()] == "ArrayTypeName":
-                # Note: dont conserve the size of the array if provided
-                # We compute it directly
-                if is_compact_ast:
-                    type_name = type_name["baseType"]
-                else:
-                    type_name = type_name["children"][0]
-                if depth > 0:
-                    # nested array
-                    array_type = ArrayType(parse_type(type_name, caller_context), array_type.length)
-                depth += 1
+            assert isinstance(array_type, ArrayType)
             array = NewArray(array_type)
             array.set_offset(src, caller_context.compilation_unit)
             return array