Merge pull request #2386 from crytic/fix/incorrect-modifier-formatting

fix: add newline to incorrect-modifier output
crytic · Mar 29, 2024 · 8786642 · 8786642
2 parents ef1fd7e + 6cc0bda
commit 8786642
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 1 deletion.
diff --git a/slither/detectors/functions/modifier.py b/slither/detectors/functions/modifier.py
@@ -89,7 +89,7 @@ def _detect(self) -> List[Output]:
                     info: DETECTOR_INFO = [
                         "Modifier ",
                         mod,
-                        " does not always execute _; or revert",
+                        " does not always execute _; or revert\n",
                     ]
 
                     res = self.generate_result(info)

diff --git a/...snapshots/detectors__detector_ModifierDefaultDetection_0_4_25_modifier_default_sol__0.txt b/...snapshots/detectors__detector_ModifierDefaultDetection_0_4_25_modifier_default_sol__0.txt
@@ -1,3 +1,6 @@
 Modifier Test.loopsNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.4.25/modifier_default.sol#30-41) does not always execute _; or revert
+
 Modifier Test.requireAssertNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.4.25/modifier_default.sol#18-22) does not always execute _; or revert
+
 Modifier Test.noResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.4.25/modifier_default.sol#2-6) does not always execute _; or revert
+
diff --git a/...snapshots/detectors__detector_ModifierDefaultDetection_0_5_16_modifier_default_sol__0.txt b/...snapshots/detectors__detector_ModifierDefaultDetection_0_5_16_modifier_default_sol__0.txt
@@ -1,3 +1,6 @@
 Modifier Test.loopsNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.5.16/modifier_default.sol#30-41) does not always execute _; or revert
+
 Modifier Test.requireAssertNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.5.16/modifier_default.sol#18-22) does not always execute _; or revert
+
 Modifier Test.noResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.5.16/modifier_default.sol#2-6) does not always execute _; or revert
+
diff --git a/...snapshots/detectors__detector_ModifierDefaultDetection_0_6_11_modifier_default_sol__0.txt b/...snapshots/detectors__detector_ModifierDefaultDetection_0_6_11_modifier_default_sol__0.txt
@@ -1,3 +1,6 @@
 Modifier Test.loopsNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.6.11/modifier_default.sol#30-41) does not always execute _; or revert
+
 Modifier Test.requireAssertNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.6.11/modifier_default.sol#18-22) does not always execute _; or revert
+
 Modifier Test.noResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.6.11/modifier_default.sol#2-6) does not always execute _; or revert
+
diff --git a/.../snapshots/detectors__detector_ModifierDefaultDetection_0_7_6_modifier_default_sol__0.txt b/.../snapshots/detectors__detector_ModifierDefaultDetection_0_7_6_modifier_default_sol__0.txt
@@ -1,3 +1,6 @@
 Modifier Test.loopsNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.7.6/modifier_default.sol#30-41) does not always execute _; or revert
+
 Modifier Test.requireAssertNoResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.7.6/modifier_default.sol#18-22) does not always execute _; or revert
+
 Modifier Test.noResult() (tests/e2e/detectors/test_data/incorrect-modifier/0.7.6/modifier_default.sol#2-6) does not always execute _; or revert
+