Skip to content

Commit

Permalink
use ValueError instead of broad exception
Browse files Browse the repository at this point in the history
  • Loading branch information
0xalpharush committed Mar 22, 2024
1 parent 609a5e1 commit 20b32df
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions slither/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@ def get_detectors_and_printers() -> Tuple[

detector = None
if not all(issubclass(detector, AbstractDetector) for detector in plugin_detectors):
raise Exception(
raise ValueError(
f"Error when loading plugin {entry_point}, {detector} is not a detector"
)
printer = None
if not all(issubclass(printer, AbstractPrinter) for printer in plugin_printers):
raise Exception(f"Error when loading plugin {entry_point}, {printer} is not a printer")
raise ValueError(f"Error when loading plugin {entry_point}, {printer} is not a printer")

# We convert those to lists in case someone returns a tuple
detectors += list(plugin_detectors)
Expand Down Expand Up @@ -215,7 +215,7 @@ def choose_detectors(
if detector in detectors:
detectors_to_run.append(detectors[detector])
else:
raise Exception(f"Error: {detector} is not a detector")
raise ValueError(f"Error: {detector} is not a detector")
detectors_to_run = sorted(detectors_to_run, key=lambda x: x.IMPACT)
return detectors_to_run

Expand Down Expand Up @@ -263,7 +263,7 @@ def choose_printers(
if printer in printers:
printers_to_run.append(printers[printer])
else:
raise Exception(f"Error: {printer} is not a printer")
raise ValueError(f"Error: {printer} is not a printer")
return printers_to_run


Expand Down Expand Up @@ -655,7 +655,7 @@ def parse_args(
args.json_types = set(args.json_types.split(",")) # type:ignore
for json_type in args.json_types:
if json_type not in JSON_OUTPUT_TYPES:
raise Exception(f'Error: "{json_type}" is not a valid JSON result output type.')
raise ValueError(f'Error: "{json_type}" is not a valid JSON result output type.')

return args

Expand Down

0 comments on commit 20b32df

Please sign in to comment.