Protect against accidental SOLC_VERSION clash from workflow #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users may set SOLC_VERSION in the workflow and cause hard-to-diagnose problems in the action (see #19). To avoid that from happening, unset SOLC_VERSION early on. If the user desires to change the solc version, they can always use the `solc-version` action option.
elopez
force-pushed
the
dev-unset-solc-version
branch
from
bf5e8b5 to
7a59832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may set SOLC_VERSION in the workflow and cause hard-to-diagnose
problems in the action (see #19). To avoid that
from happening, unset SOLC_VERSION early on. If the user desires
to change the solc version, they can always use the
solc-versionaction option.
Closes: #19