Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Slither fail_* options #28

Closed
elopez opened this issue Aug 16, 2022 · 0 comments
Closed

Add support for new Slither fail_* options #28

elopez opened this issue Aug 16, 2022 · 0 comments
Milestone

Comments

@elopez
Copy link
Member

elopez commented Aug 16, 2022

Slither has added a breaking change affecting the exit code, it will now only exit non-zero in case of a traceback/error. This means that actions running after a new slither version is released will start to pass all the time unless slither crashes.

We should document this change and offer a way to adjust this behavior.

A way forward could be a new fail-on: [all/none/low/medium/high] with a default of all to maintain the current action behavior.

https://github.com/crytic/slither/blob/475de74d9b9c0329fe2f78bcc10aa60485997cc9/slither/__main__.py#L398-L424

@elopez elopez added this to the v0.2 milestone Sep 5, 2022
elopez added a commit that referenced this issue Sep 7, 2022
@elopez elopez closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant