Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed etherlime from CI #378

Merged
merged 5 commits into from
Feb 13, 2023
Merged

removed etherlime from CI #378

merged 5 commits into from
Feb 13, 2023

Conversation

damilolaedwards
Copy link
Contributor

This fixes issue #327, removing etherlime test commands from CI script

elopez
elopez requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! As this removes the id: node step, you should also update/remove any other references to it. There's one remaining on the line that reads node-version: ${{ steps.node.outputs.version }}; replacing it with node-version: 'lts/*' should suffice 😄

@damilolaedwards
Copy link
Contributor Author

Hi @elopez thanks for the really helpful comment
the patch has been made, ready for review & merge

@montyly montyly added this pull request to the merge queue Feb 13, 2023
Merged via the queue into dev with commit 40f58f7 Feb 13, 2023
@montyly montyly deleted the fix-ci branch February 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elopez elopez elopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damilolaedwards @elopez @montyly