Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple compilation units for foundry (2) #348

Merged
merged 10 commits into from
Jan 10, 2023

Conversation

montyly
Copy link
Member

@montyly montyly commented Jan 9, 2023

Something fishy is going on with mypy on #334. I am trying to debug it

@montyly
Copy link
Member Author

montyly commented Jan 9, 2023

Turned out, this was the issue:

hardhat_working_dir = str(Path(self._target, detected_paths["root"]))

A change made in dev, but this branch was not up to date with dev :)

I also changed the message here:

txt = f"`compile` failed. Can you run it?\n{build_directory} is empty"
. Previously it would show "hardhat compile failed for foundry, not it only mentions the that the compile failed.

@0xalpharush / @bohendo : could one of you do a review, to make sure I did not mess up with #334

@0xalpharush
Copy link
Contributor

Tested on 3 repos and seems to not have broken anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants