Node module resolution #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohendo
commented
Dec 16, 2022
This reverts commit 7f7047b.
added 7 commits
December 16, 2022 12:54
montyly
reviewed
Dec 22, 2022
pyproject.toml
Outdated
| @@ -11,6 +11,7 @@ invalid-name, | |||
| fixme, | |||
| too-many-return-statements, | |||
| too-many-ancestors, | |||
| too-many-statements, | |||
There was a problem hiding this comment.
I am not sure about removing this warning. If pylint raises this its usually because a function would benefit from being split between internal functions
Remove working_dir usage to reduce complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues related to improper resolution of dependencies from
node_modules:fixes #279
fixes #258
fixes #321
fixes #305
fixes #290
fixes #255