Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple compilation units #167

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Conversation

montyly
Copy link
Member

@montyly montyly commented Apr 7, 2021

This PR is a breaking change. The CryticCompile objects now has a compilation_units dictionary, which maps a unique key (str) to a CompilationUnit object.

A lot of functions from CryticCompile are moved to CompilationUnit. This also leads the export functions to generate multiple json files (this will need to be taken into account into Echidna).

For now, only hardhat supports the multi compilation units. I think brownie might support it too (needs investigation)

This PR requires to adapt the following tools:

  • Slither
  • Manticore
  • evm-cfg-builder
  • Echidna
  • Oyente

Fix #164.

This is a breaking change (see the PR notes)

 Please enter the commit message for your changes. Lines starting
@montyly
Copy link
Member Author

montyly commented Apr 23, 2021

Todo: if there is one compilation unit, the solc output should be crytic-export/combined_solc.json; this will ease Echidna's integration

montyly added a commit to trailofbits/manticore that referenced this pull request Apr 26, 2021
@montyly montyly merged commit b547d03 into dev Apr 27, 2021
@montyly montyly deleted the dev-compilation-units branch May 7, 2021 14:36
ehennenfent pushed a commit to trailofbits/manticore that referenced this pull request May 10, 2021
* Add support for multiple compilation units
See crytic/crytic-compile#167

* update setup.py

* Use crytic-compile@master

* Update setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant