Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build targets from shards.yml #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tribela
Copy link

@tribela tribela commented Aug 12, 2018

Sometimes multiple target is needed. bin/compile should build all of it's targets.

@bcardiff
Copy link
Member

Yes there might be needed, but the problem is that the user needs to edit manually the Procfile to let heroku know which process is the webserver.

Ideally if there is only one target that should be used without manual Procfile. So the last case of the if can be supported in a natural way (and solving #33).

Also with the PR as is the last case of the if is never reached since the shard.yml is always present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants