Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config instead of pkgconf package #22

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Oct 10, 2018

@bcardiff bcardiff requested a review from RX14 October 10, 2018 12:54
@RX14
Copy link
Contributor

RX14 commented Oct 10, 2018

What was the error using pkgconf?

@bcardiff
Copy link
Member Author

The .deb is installed directly in the scripts, and the dependency was not satisfied https://circleci.com/gh/crystal-lang/crystal/12757
That could be fixed of course.

But then I get into knowing (the readme of) pkgconf and notice it require some tweaks in the environment to be a replacement for pkg-config. Either env var or symlink needs to be created. Ref: https://github.com/pkgconf/pkgconf.

That bring me to #19 (comment) and why one package would be preferred over the other.

@RX14
Copy link
Contributor

RX14 commented Oct 10, 2018

@bcardiff i guess pkgconf isn't available on all supported versions of debian/ubuntu yet.

@RX14 RX14 merged commit b586ac6 into master Oct 10, 2018
@bcardiff bcardiff deleted the deps/pkg-config-deb branch March 25, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants