Compiler: fix proc of self causing multidispatch #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
bcardiff
approved these changes
Nov 25, 2020
|
Well, I lied. There's #3822 but I'll fix it in this PR too. We should always do the replacement if there's no |
|
Done! Ready for another review. |
|
There's something wrong in what I did but I'll fix it in the next days |
|
CI is green! Ready for another review. |
bcardiff
approved these changes
Dec 1, 2020
|
Just a heads up this PR broke some stuff in https://github.com/athena-framework/validator. I'm working up a reduction and will create an issue when I got something reproducible. EDIT: See #9972. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9823
Fixes #3822
We rewrite
->foo(X)to->(x : X) { foo(x) }in caseselfin that context could cause a multi-dispatch. This is similar to #9824I believe with this, Procs don't have any more bugs (that I am aware of, so this is probably a lie 😛 )