Re-introduce canonical URL for docs generator #9917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt to use sitemaps to indicate preference of latest version over older ones to search engines doesn't seem to work. Instead, the solution applied for similar situations is canonical links. This mostly reinstates the canonical link behaviour prior to crystal-lang#8348
jhass
approved these changes
Nov 29, 2020
|
I don't think anyone can really tell. But it seems to be what most others are doing. And the alternative doesn't seem to work. |
bcardiff
approved these changes
Dec 1, 2020
|
We need to tweak the Makefile docs target or change the DOCS_OPTIONS env variable in bin/ci and in distribution-scripts after 1.0 then. |
|
Yes, I'll do that as soon as this gets merged. |
This was referenced Dec 1, 2020
|
I guess the bin/ci change could've been included here directly. But here it is: #10007 and crystal-lang/distribution-scripts#77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt in #8348 to use sitemaps to indicate preference of latest version over older ones to search engines doesn't seem to work. Instead, the solution applied for similar situations is canonical links. This mostly reinstates the canonical link behaviour prior to #8348
Hopefully finally resolves most of #5952