-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix YAML spec for libyaml 0.2.1 #6285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good fix because it can hide real errors.
@straight-shoota Suggestions for a good fix? :-) There's nothing in YAML that can generate "...\n" at the end of the document other than a document. I really don't think we should put a lot more effort into this. |
Take a look at the affected examples. There are very similar examples, which sometimes expect I'd suggest to add an argument flag |
Sounds good, but I don't have more time for Crystal today, so someone else should send a PR. |
It's probably more correct to change the expected string based on the YAML version, so that's another solution. Of course, if later in libyaml 0.2.2 they revert that change because it was a mistake, our code will have to change again. |
Actually, it would probably even be better to normalize the results from |
Fixes #6283