Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to codemirror 5.38.0 #6166

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Update to codemirror 5.38.0 #6166

merged 1 commit into from
Jun 8, 2018

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Jun 7, 2018

Superseed #6089 and includes a couple of improvements and fixes in the crystal mode of codemirror

Ref: codemirror/codemirror5#4551

@bcardiff bcardiff mentioned this pull request Jun 7, 2018
Closed
@j8r
Copy link
Contributor

j8r commented Jun 7, 2018

Note this type of change can be better by using a package.json and use https://www.npmjs.com/package/codemirror . This implies #6083 (comment)

@RX14
Copy link
Contributor

RX14 commented Jun 8, 2018 •
edited
Loading

And no, we're not going to make building crystal depend on npm. The further crystal is away from npm the better...

@bcardiff bcardiff merged commit 7e8b219 into crystal-lang:master Jun 8, 2018
@bcardiff bcardiff added this to the 0.25.0 milestone Jun 8, 2018
@j8r
Copy link
Contributor

j8r commented Jun 8, 2018

@RX14 Indeed. That's one of the point to move out playground from the crystal compiler...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooster0 wooster0 wooster0 approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
topic:tools:playground
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bcardiff @j8r @RX14 @wooster0