Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same llvm's version as crystal-lang package for CI's darwin build #5804

Merged
merged 4 commits into from
Mar 11, 2018
Merged

Use the same llvm's version as crystal-lang package for CI's darwin build #5804

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfd5724
Use llvm5 for darwin build in CI
bew Mar 11, 2018
273f781
Force binaries of llvm in PATH
bew Mar 11, 2018
e09b818
DRY for the llvm's version crystal-lang's depends on
bew Mar 11, 2018
20fbfd1
Install jq
bew Mar 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bin/ci
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,10 @@ prepare_build() {

on_linux docker pull "jhass/crystal-build-$ARCH"

on_osx brew install llvm crystal-lang
on_osx brew install llvm@5 crystal-lang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crystal-lang itself currently depends on llvm@5, so it's not necessary to install it.

We do need to link it, though - we can get the currently depended llvm version via jq with brew info --json=v1 crystal-lang | jq '.[].dependencies | .[] | select(startswith("llvm"))'. Not sure if overkill, but avoiding re-specifying the LLVM version we need seems sweet.

Copy link
Contributor Author

@bew bew Mar 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked perfectly ;)


# Make sure binaries from llvm are available in PATH
on_osx brew link --force llvm@5
}

with_build_env() {
Expand Down