Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for SSL::Context default_verify_param #5601

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Fix default value for SSL::Context default_verify_param #5601

merged 1 commit into from
Jan 25, 2018

Commits on Jan 25, 2018

  1. Bug: default_verify_param are inverted in SSL::Context::Client and SS… 

    …L::Context::Server

Fixes #5266

x509 certificates have a purpose associated to them. Clients should
verify that the server's certificate is intended to be used in a
server, and servers should check the client's certificate is
intended to be used for clients.

Crystal was mistakingly checking those mixed up.

See https://wiki.openssl.org/index.php?title=Manual:X509(1)&oldid=1797#CERTIFICATE_EXTENSIONS
See https://tools.ietf.org/html/rfc5280#section-4.2.1.3
    @waj @matiasgarciaisaia
    waj authored and matiasgarciaisaia committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    624ebb5 View commit details
    Browse the repository at this point in the history