-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanatory message to linker command output on link failure #5486
Conversation
49e55ba
to
b45727e
Compare
I like this. I always thought about doing this but was lazy to. Maybe we could show the relevant messages at the end of the compilation? I think having those new messages intermixed with everything else makes them easier to miss. Alternatively, we could show those messages in yellow, similar to Yet another possibility is even checking what |
@asterite yeah I think highlighting in yellow is a good idea. I'll do that. |
Added colour highlighting. |
Just tried this in mac: it doesn't work. The error I get is:
so we probably need a different path for mac. |
On that note: a test file
Running this should produce the error. |
@asterite The difference is I'll just replace both strings on all platforms. |
Fixed when using |
Still doesn't work for me. None of the
|
@asterite oh, looks like the strings are different on my lld to yours... |
Mmm... I'm using |
dbd8959
to
bab049e
Compare
When the linker fails to find shared object files, print an explanatory message after the original output to aid users in debugging their problem.
bab049e
to
42c56cd
Compare
@asterite updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it works now! 🎉
When the linker fails to find shared object files, print an explanatory message after the original output to aid users in debugging their problem.
See #5291.