Fixed #2624: Running multiple macro runs doesn't work #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
force-pushed
the
feature/fix_cache_tempfiles
branch
from
29c1c31
to
ce10bc5
Compare
|
I also moved the cleanup line to be after the compilation finishes. Before this it was right before doing codegen but that would sometimes make some needed files be deleted before the compilation. |
asterite
pushed a commit
that referenced
this pull request
May 20, 2016
keplersj
added a commit
to keplersj/crystal
that referenced
this pull request
May 21, 2016
* master: (69 commits) Fixed: splat restriction and double splat restriction didn't match empty tuple/named-tuple Fixed crystal-lang#1203: allow using free var to match the size of a static array Updated Changelog Compiler: don't remove old directories when compiling macro run programs. Related to crystal-lang#2625 Fixed crystal-lang#2624: Running multiple macro runs doesn't work Docker: Preinstall git in released docker image Update and fix TypeNode macro method docs Fixed wrong datatype in 0.17 branch Docs: use `*` and `**` before type argument for Tuple and NamedTuple Docs: use `*` and `**` before type argument for Tuple and NamedTuple Compiler: allow a double splat restriction on a double splat argument Compiler: allow a splat restriction on a splat argument Compiler: allow restriction in double splat Compiler: guess type from captured block without restriction Fixed crystal-lang#731: initialize's default arguments are incorrectly evaluated at the class scope Fixed crystal-lang#2619: wrong codegen for global variable assignment in type declaration Compiler: allow a double splat restriction on a double splat argument Compiler: allow a splat restriction on a splat argument Compiler: allow restriction in double splat Compiler: guess type from captured block without restriction ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
macro runinside the cache directory related to the program being compiled (as suggested by @jhass)macro runcalls are deleted