Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dereferencing symlinks in make install #15138

Merged

Conversation

HertzDevil
Copy link
Contributor

On platforms without complete symbolic link support (e.g. native MSYS2 environments), make install deref_symlinks=1 will dereference the individual directories under src/lib_c and copy the contents, instead of copying the directories as symbolic links.

@straight-shoota
Copy link
Member

I suppose this could be fine as a quick fix for installation. But symlinks in the repo itself are still unusable. bin/crystal won't be able to pick up the symlinked lib paths (cf. #6170 (comment)). I think this should really work as well, so we should find a general solution (eg. #6170 (comment)).

I'm fine with merging this as a temporary measure though.

@HertzDevil
Copy link
Contributor Author

You could share a Crystal Git repository that is created outside MSYS2, but make installed inside MSYS2 (e.g. for packaging), so this is still useful on its own.

@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 30, 2024
@straight-shoota straight-shoota merged commit d353bb4 into crystal-lang:master Oct 31, 2024
69 checks passed
@straight-shoota straight-shoota changed the title Support deferencing symlinks in make install Support dereferencing symlinks in make install Oct 31, 2024
@HertzDevil HertzDevil deleted the feature/make-install-symlink branch October 31, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants