Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cc's search paths to Unix dynamic library loader #15127

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add cc's search paths to Unix dynamic library loader #15127

merged 2 commits into from
Oct 28, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14398.

@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 25, 2024
@HertzDevil
Copy link
Contributor Author

So apparently $(src/llvm/ext/find-llvm-config) --ldflags is now giving me -L/opt/homebrew/Cellar/llvm@18/18.1.8/lib -Wl,-search_paths_first -Wl,-headerpad_max_install_names on macOS, and the loader thinks it is an unknown option rather than unknown argument?

@straight-shoota straight-shoota merged commit be1e1e5 into crystal-lang:master Oct 28, 2024
67 of 69 checks passed
@HertzDevil HertzDevil mentioned this pull request Oct 29, 2024
Merged
@HertzDevil HertzDevil deleted the feature/interpreter-cc-search-dirs branch October 30, 2024 17:07
CTC97 pushed a commit to CTC97/crystal that referenced this pull request Nov 9, 2024
@HertzDevil @CTC97
Add cc's search paths to Unix dynamic library loader (crystal-lang#…
5738e45 
…15127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature platform:unix topic:compiler:interpreter
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Detecting libstdc++.so in the interpreter
2 participants
@HertzDevil @straight-shoota