Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract def parameter name in LibEvent::EventLoop#send_to #14658

Conversation

straight-shoota
Copy link
Member

Fixup for #14643

@ysbaddaden
Copy link
Contributor

I believe the other implementations are also affected:

src/crystal/system/wasi/event_loop.cr
55:  def send_to(socket : ::Socket, slice : Bytes, addr : ::Socket::Address) : Int32

src/crystal/system/win32/event_loop_iocp.cr
182:  def send_to(socket : ::Socket, bytes : Bytes, addr : ::Socket::Address) : Int32

@ysbaddaden
Copy link
Contributor

And now it complains about the bytes param on Windows 😩

@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 4, 2024
@straight-shoota straight-shoota merged commit 4bc7202 into crystal-lang:master Jun 4, 2024
61 checks passed
@straight-shoota straight-shoota deleted the fix/event_loop-abstract-def-parameter-name branch June 4, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants