OpenSSL: deprecate Mozilla's TLS Server recommendation #14657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beta-ziliani
reviewed
Jun 5, 2024
straight-shoota
added
kind:bug
We shouldn't hardcode a list of ciphers. It should always be a configurable list of ciphers. Furthermore, restricting the ciphers is only part of the security recommendations: TLS methods, curves and so on must also be considered. This patch deprecates the constants, and makes the related methods as NOOP since they didn't work as expected on OpenSSL 1.1 and later, as they only changes the cipher suites for TLS v1.3 (identical to default) and didn't change the ciphers list for TLS v1.2 and below (oops).
ysbaddaden
force-pushed
the
fix/openssl-deprecate-mozilla-recommendation
branch
from
e34f693 to
76a1fcd
Compare
Sija
reviewed
Jun 6, 2024
straight-shoota
approved these changes
Jun 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't hardcode a list of ciphers. It should always be a runtime configurable list. Furthermore, restricting the ciphers is only part of the security recommendations: TLS methods, curves and so on must also be considered.
This patch deprecates the constants and makes the related methods as NOOP since they didn't work as expected on OpenSSL 1.1 and later, as they only changed the cipher suites for TLS v1.3 (identical to default, at least for OpenSSL 1.1.1f) and didn't change the ciphers list for TLS v1.2 and below (oops).
follow up to #14655 and #14656