Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify LLVM dependency in shell.nix #14590

Merged
merged 3 commits into from
May 15, 2024
Merged

Simplify LLVM dependency in shell.nix #14590

merged 3 commits into from
May 15, 2024

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented May 13, 2024 •
edited
Loading

There's no need to explicitly list all LLVM versions. We can directly infer llvmPackages_X from the llvm version number.

@straight-shoota straight-shoota self-assigned this May 13, 2024
@straight-shoota straight-shoota mentioned this pull request May 13, 2024
Closed
@straight-shoota straight-shoota added this to the 1.13.0 milestone May 13, 2024
@straight-shoota straight-shoota merged commit 52bbe7f into crystal-lang:master May 15, 2024
48 checks passed
@straight-shoota straight-shoota deleted the infra/shell.nix-simplify-llvm branch May 15, 2024 08:20
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

Assignees

@straight-shoota straight-shoota

Labels
topic:infrastructure
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @bcardiff