Disable implicit execution of batch files on Windows #14557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
breaking-change
platform:windows
Co-authored-by: Oleh Prypin <[email protected]>
oprypin
approved these changes
May 3, 2024
straight-shoota
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disables the implicit execution of batch files (i.e. path name extension
.bator.cmd, case-insensitive) inProcess.runon Windows withshell: false(default). There are no effects on other operating systems.The disabled behaviour is an irrational and potentially dangerous feature of
CreateProcessWwhich is not intended forProcess.run.If you want to run a batch file on Windows, you need to launch it through a shell, either implicitly with
shell: trueor explicitly by runningcmd.exewith the batch file as argument.The semantics are different on POSIX platforms where you can directly execute a shell script if it has a shebang. The mechanism on Windows works differently, as
CreateProcessWimplicitly injectscmd.exe /cwhich changes the semantics of run arguments.A similar approach has been taken by node.js: nodejs/node@64b6777
Resolves #14536