Thread owns its current fiber (instead of Crystal::Scheduler)
#14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
straight-shoota
approved these changes
May 2, 2024
yxhuvud
reviewed
May 2, 2024
Co-authored-by: Johannes Müller <[email protected]>
straight-shoota
approved these changes
May 2, 2024
straight-shoota
changed the title
Thread owns its current fiber (instead of Crystal::Scheduler)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the reference to the running Fiber from
Crystal::SchedulertoThread. This way the thread itself knows which fiber is currently running, independently of any scheduling.This allows the GC collection callback as well as
Fiber.currentto accessThread#current_fiberdirectly, without having to know anything about the schedulers.This is part 1 of abstracting
Crystal::Scheduleraway.