Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize String#index(Char) and #rindex(Char) for invalid UTF-8 #14461

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Optimize String#index(Char) and #rindex(Char) for invalid UTF-8 #14461

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
094fb35
Optimize `String#index(Char)` and `#rindex(Char)` for invalid UTF-8
HertzDevil Apr 8, 2024
e86631e
Update src/string.cr
HertzDevil Apr 9, 2024
599cef3
Update src/string.cr
HertzDevil Apr 9, 2024
7e2e901
Update src/string.cr
HertzDevil Apr 9, 2024
30b90f4
`crystal tool format`
straight-shoota Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/string.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3334,7 +3334,11 @@ class String
# ```
def index(search : Char, offset = 0) : Int32?
# If it's ASCII we can delegate to slice
if search.ascii? && single_byte_optimizable?
if single_byte_optimizable?
# With `single_byte_optimizable?` there are only ASCII characters and invalid UTF-8 byte
# sequences and we can immediately reject any non-ASCII codepoint.
return unless search.ascii?

return to_slice.fast_index(search.ord.to_u8, offset)
end

Expand Down Expand Up @@ -3445,7 +3449,11 @@ class String
# ```
def rindex(search : Char, offset = size - 1)
# If it's ASCII we can delegate to slice
if search.ascii? && single_byte_optimizable?
if single_byte_optimizable?
# With `single_byte_optimizable?` there are only ASCII characters and invalid UTF-8 byte
# sequences and we can immediately reject any non-ASCII codepoint.
return unless search.ascii?

return to_slice.rindex(search.ord.to_u8, offset)
end

Expand Down
Loading