This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Analyze files with implicit requires #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add method inside_crystal_path? to avoid analizing lib and stdlib * Send clean diagnostics for all files when a full project is analyzed * Allow analyze files with implicit requires (main file style) * Adds --no-debug flag for speed up compilation * Add fake file .scry.cr to analyze a full project (aka main file) * Remove the fake file .scry.cr from diagnostic list * Add untitled: to the uri_to_filename method
|
About the spec: as same as I said on #78, Actually the current tests already cover this feature. To create a full test for this we need a full workspace, so is a bit harder that common specs.I think those kind of specs can be implemented on other PR. |
keplersj
approved these changes
Apr 9, 2018
bmulvihill
approved these changes
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically adds the following feature: Analyze the code twice if undefined symbol is found on diagnostics result
The rules:
Summary of changes:
Use case: very useful on those projects where you have a main file that require all other files, allowing you to write your code without multiple
requires in every fileFixes #29 as well
Related to #78 (This allows to remove the errors across files when you search implementations)