Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Adds documentation resolve to method completion #55

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

laginha87
Copy link
Contributor

@laginha87 laginha87 commented Mar 7, 2018

Adds the method signature to the completion box and the documentation of the method if it has any.

ezgif com-video-to-gif 1
ezgif com-video-to-gif

Copy link
Member

@faustinoaq faustinoaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and works out-the-box

@faustinoaq
Copy link
Member

@laginha87 I messed up the commit history trying to release v0.7.0 I apologize for this 😓

I already published v0.7.0 successfully but this PR have some commits that don't exist on master, so, can you please --force a sync with master repo? 😅

@laginha87
Copy link
Contributor Author

no worries I'll do that when I can 👍

@laginha87 laginha87 force-pushed the fcorreia-add-method-resolve branch from 8ceed5a to d91677f Compare March 7, 2018 19:12
Copy link
Contributor

@bmulvihill bmulvihill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@faustinoaq faustinoaq merged commit ca14fd8 into master Mar 7, 2018
@faustinoaq faustinoaq deleted the fcorreia-add-method-resolve branch March 7, 2018 22:07
@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

Works awesome on Atom ❤️

@bew
Copy link
Contributor

bew commented Mar 8, 2018

Is there a way (in Atom, VSCode or others) to see the function arguments in the list rather than having to highlight an element to see its documentation, which contains the arguments?

@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

Like method signature tooltips? ide-typescript does this:

screen shot 2018-03-07 at 6 56 08 pm

@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

Here's corresponding LSP Documentation: Signature Help Request

@bew
Copy link
Contributor

bew commented Mar 8, 2018

Nice one, but I meant in the completion menu

@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

Like so?
screen shot 2018-03-07 at 7 18 21 pm

@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

I see method signatures in list on atom-ide-crystal...

screen shot 2018-03-07 at 7 23 16 pm

@bew
Copy link
Contributor

bew commented Mar 8, 2018

Yes, this is what I was thinking about!

@faustinoaq
Copy link
Member

faustinoaq commented Mar 8, 2018

@keplersj your screen captures look awesome! 👍 I'll give a try to atom again 😄

@keplersj
Copy link
Contributor

keplersj commented Mar 8, 2018

@faustinoaq Part of the reason I love Atom is the design of the thing. They have an awesome designer on the team. I mean look no further than the design for the Atom IDE website:

screen shot 2018-03-07 at 8 12 42 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants