This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Add symbol end_position using end_location #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome ❤️ almost API search with code outline ✨ |
bew
reviewed
May 6, 2018
src/scry/symbol.cr
Outdated
| range = Range.new(position, position) | ||
| location = Location.new(@document_uri, range) | ||
| end_location = node.end_location | ||
| if end_location |
There was a problem hiding this comment.
you can do if end_location = node.end_location, I think it shows better that end_location won't be used outside the if
bew
reviewed
May 6, 2018
src/scry/symbol.cr
Outdated
|
|
||
| range = Range.new(position, end_position) | ||
| location = Location.new(@document_uri, range) | ||
| @symbols << SymbolInformation.new(name, kind, location, @container.join("::")) | ||
| true |
There was a problem hiding this comment.
Note: true is useless here, and same for return true unless location at the beginning of that method.
bew
approved these changes
May 6, 2018
bmulvihill
approved these changes
May 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found this enhancement during development of rename feature
This will allow us to show code outline properly 🎉