Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the Makefile a subtle massage #479

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Give the Makefile a subtle massage #479

merged 1 commit into from
Oct 11, 2024

Conversation

Sija
Copy link
Member

@Sija Sija commented Oct 11, 2024

No description provided.

@Sija Sija added this to the 1.6.3 milestone Oct 11, 2024
@Sija Sija requested a review from veelenga October 11, 2024 02:53
@Sija Sija self-assigned this Oct 11, 2024
@Sija Sija enabled auto-merge October 11, 2024 02:54
@Sija Sija merged commit 3d4d84e into master Oct 11, 2024
2 of 4 checks passed
@Sija Sija deleted the makefile-massage branch October 11, 2024 05:37
DESTDIR ?= ## Install destination dir
PREFIX ?= /usr/local## Install path prefix
DESTDIR ?= ## Install destination dir
PREFIX ?= /usr/local ## Install path prefix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This change breaks behaviour.
Unfortunately, GNU make does not chop off trailing whitespace from string values in assignments. So the default BINDIR is now /usr/local /bin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh... I'll revert that, thanks for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants