fix: correctly calculate resource timing duration (nodejs#1988)

crysmags · Feb 27, 2024 · b7ea0c5 · b7ea0c5
1 parent b39cce9
commit b7ea0c5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/fetch/index.js b/lib/fetch/index.js
@@ -297,7 +297,7 @@ function finalizeAndReportTiming (response, initiatorType = 'other') {
   // capability.
   // TODO: given global’s relevant settings object’s cross-origin isolated
   // capability?
-  response.timingInfo.endTime = coarsenedSharedCurrentTime()
+  timingInfo.endTime = coarsenedSharedCurrentTime()
 
   // 10. Set response’s timing info to timingInfo.
   response.timingInfo = timingInfo

diff --git a/test/fetch/resource-timing.js b/test/fetch/resource-timing.js
@@ -13,7 +13,7 @@ const {
 const skip = nodeMajor < 18 || (nodeMajor === 18 && nodeMinor < 2)
 
 test('should create a PerformanceResourceTiming after each fetch request', { skip }, (t) => {
-  t.plan(4)
+  t.plan(6)
   const obs = new PerformanceObserver(list => {
     const entries = list.getEntries()
     t.equal(entries.length, 1)
@@ -25,6 +25,9 @@ test('should create a PerformanceResourceTiming after each fetch request', { ski
     })
     t.strictSame(entry.entryType, 'resource')
 
+    t.ok(entry.duration >= 0)
+    t.ok(entry.startTime >= 0)
+
     obs.disconnect()
     performance.clearResourceTimings()
   })